Skip to content

Conversation

@joelanford
Copy link
Member

@joelanford joelanford commented Feb 3, 2022

Description of the change:

  • Removes the release.yaml github action that built and published linux/windows/darwin amd64 binaries to github release.
  • Added goreleaser configurations for windows and darwin builds.
  • Added a new darwin/arm64 target to support Apple Silicon.
  • Linux binaries in the github release are now identical to linux binaries in the published container images.
  • Added checksum.txt to the release assets, containing sha265 of each binary.

Motivation for the change:
Closes #526
Supersedes #913 and #631
Follows up on #710

NOTE: Still need to add binary signing requested in #232

Example release produced by this action in my fork: https://github.com/joelanford/operator-registry/releases/tag/v1.19.6

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@joelanford joelanford added this to the 1.20.0 milestone Feb 3, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelanford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2022
@joelanford joelanford removed this from the 1.20.0 milestone Feb 3, 2022
…onfigs

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #914 (7ccd299) into master (00dbb12) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #914   +/-   ##
=======================================
  Coverage   52.18%   52.18%           
=======================================
  Files         103      103           
  Lines        9113     9113           
=======================================
  Hits         4756     4756           
  Misses       3451     3451           
  Partials      906      906           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00dbb12...7ccd299. Read the comment docs.

@kevinrizza
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2022
@openshift-merge-robot openshift-merge-robot merged commit 0b008de into operator-framework:master Feb 3, 2022
@joelanford joelanford deleted the goreleaser-all-os branch January 4, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add hashes for release binaries

3 participants