Skip to content

Conversation

@timflannagan
Copy link
Member

@timflannagan timflannagan commented Jul 27, 2022

Description of the change:
Update the repository from ginkgo v1 to ginkgo v2.

Motivation for the change:
Align ginkgo version with the other major OLM repositories.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

Closes #997

Signed-off-by: timflannagan <timflannagan@gmail.com>
@timflannagan timflannagan changed the title Bump ginkgo v2 Bump the github.com/onsi/ginkgo dependency to v2 Jul 27, 2022
@openshift-ci openshift-ci bot requested review from exdx and joelanford July 27, 2022 15:18
@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #998 (5590010) into master (2a21178) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 5590010 differs from pull request most recent head 0037c38. Consider uploading reports for the commit 0037c38 to get more accurate results

@@            Coverage Diff             @@
##           master     #998      +/-   ##
==========================================
- Coverage   52.88%   52.87%   -0.02%     
==========================================
  Files         104      104              
  Lines        9468     9468              
==========================================
- Hits         5007     5006       -1     
- Misses       3528     3529       +1     
  Partials      933      933              
Impacted Files Coverage Δ
alpha/veneer/semver/semver.go 61.85% <0.00%> (-0.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a21178...0037c38. Read the comment docs.

@timflannagan
Copy link
Member Author

It looks like that codecov check is off given https://app.codecov.io/gh/operator-framework/operator-registry/commit/f8f3f89000b8341095723f677e65b2528295f6ec reports that the difference is with some veneer semver code, but there are zero changes to anything that touches any of the pkg/test files in that domain.

Copy link
Contributor

@ankitathomas ankitathomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one small nit about the docs

Signed-off-by: timflannagan <timflannagan@gmail.com>
@ankitathomas
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2022
@grokspawn
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankitathomas, grokspawn, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2022
@openshift-merge-robot openshift-merge-robot merged commit 6ac352f into operator-framework:master Jul 28, 2022
@timflannagan timflannagan deleted the bump-ginkgo-v2 branch July 28, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump github.com/onsi/ginkgo to v2

4 participants