-
Notifications
You must be signed in to change notification settings - Fork 261
Bump the github.com/onsi/ginkgo dependency to v2 #998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump the github.com/onsi/ginkgo dependency to v2 #998
Conversation
Signed-off-by: timflannagan <timflannagan@gmail.com>
c1e8d96 to
f8f3f89
Compare
Codecov Report
@@ Coverage Diff @@
## master #998 +/- ##
==========================================
- Coverage 52.88% 52.87% -0.02%
==========================================
Files 104 104
Lines 9468 9468
==========================================
- Hits 5007 5006 -1
- Misses 3528 3529 +1
Partials 933 933
Continue to review full report at Codecov.
|
|
It looks like that codecov check is off given https://app.codecov.io/gh/operator-framework/operator-registry/commit/f8f3f89000b8341095723f677e65b2528295f6ec reports that the difference is with some veneer semver code, but there are zero changes to anything that touches any of the pkg/test files in that domain. |
ankitathomas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one small nit about the docs
Signed-off-by: timflannagan <timflannagan@gmail.com>
f8f3f89 to
0037c38
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ankitathomas, grokspawn, timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of the change:
Update the repository from ginkgo v1 to ginkgo v2.
Motivation for the change:
Align ginkgo version with the other major OLM repositories.
Reviewer Checklist
/docsCloses #997