Swap out openshift client for kubernetes client #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the functionality provided by the openshift client library has been upstreamed to the kubernetes client library, so it's no longer necessary for both of these. This also switches community.kubernetes to kubernetes.core as the former has been deprecated for some time now. This change only affects the testing and is a drop in replacement.
everettraven
approved these changes
Jun 30, 2023
Contributor
everettraven
left a comment
everettraven
left a comment
There was a problem hiding this comment.
Thanks for this @gravesm ! These changes look good to me
/lgtm
|
Looks good to me too! Thank you so much for this PR!! |
This upgrades the test suite to use ansible 2.15. This update triggers a number of other changes that have to be made. Molecule no longer handles linting, so linting has to be handled by ansible-lint now. Running ansible-lint generate quite a few linting issues. I've corrected enough of the linting issues to get it to pass using the security profile. The upgrade to ansible 2.15 also generated quited a few new sanity errors. I've fixed all the documentation errors. Apparently, "message" is a reserved module parameter, however. For now, I've added a sanity ignore for this, which affects the k8s_event and k8s_status modules. This parameter should probably be renamed, but this would obviously be a breaking change.
|
New changes are detected. LGTM label has been removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the functionality provided by the openshift client library has been upstreamed to the kubernetes client library, so it's no longer necessary for both of these.
This also switches community.kubernetes to kubernetes.core as the former has been deprecated for some time now. This change only affects the testing and is a drop in replacement.