Skip to content

updating unit test make cmd to add -race flag #7024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2025
+9 −5
Merged

updating unit test make cmd to add -race flag #7024

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cabb231
updating unit test make cmd to add -race flag
acornett21 Nov 18, 2025
033aeaa
fixing race condition in external go, ensure cmd has finished
acornett21 Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ test-docs: ## Test doc links
.PHONY: test-unit
TEST_PKGS = $(shell $(GO) list ./... | grep -v -E 'github.com/operator-framework/operator-sdk/test/')
test-unit: ## Run unit tests
$(GO) test -tags=$(GO_BUILD_TAGS) -coverprofile=coverage.out -covermode=count -short $(TEST_PKGS)
CGO_ENABLED=1 $(GO) test -race -tags=$(GO_BUILD_TAGS) -coverprofile=coverage.out -covermode=atomic -short $(TEST_PKGS)

e2e_tests := test-e2e-go test-e2e-helm test-e2e-integration
e2e_targets := test-e2e $(e2e_tests)
Expand Down
12 changes: 8 additions & 4 deletions internal/validate/external.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,13 +64,17 @@ func RunExternalValidators(ctx context.Context, entrypoints []string, bundleRoot
dec := json.NewDecoder(stdout)
dec.DisallowUnknownFields()

if err := dec.Decode(&manifestresults[i]); err != nil {
fmt.Printf("decode failed: %v\n", err)
return nil, err
}
decodeErr := dec.Decode(&manifestresults[i])
// Always wait for the command to finish to ensure stderr is fully written
// and all goroutines complete before returning.
if err := cmd.Wait(); err != nil {
return nil, err
}
// Return decode error after waiting for command to complete
if decodeErr != nil {
fmt.Printf("decode failed: %v\n", decodeErr)
return nil, decodeErr
}
}
return manifestresults, nil
}
Loading