Skip to content
This repository was archived by the owner on Aug 12, 2024. It is now read-only.

e2e test private git repository#416

Merged
akihikokuroda merged 1 commit into
operator-framework:mainfrom
akihikokuroda:privategittest
Jun 28, 2022
Merged

e2e test private git repository#416
akihikokuroda merged 1 commit into
operator-framework:mainfrom
akihikokuroda:privategittest

Conversation

@akihikokuroda
Copy link
Copy Markdown
Member

@akihikokuroda akihikokuroda commented Jun 3, 2022 •
edited
Loading

Signed-off-by: akihikokuroda akuroda@us.ibm.com

Closes #415

This PR has one additional test that accesses to a private git repository via https scheme. The following environment variables must be set to enable and execute the test

PRIVATE_REPO
PRIVATE_REPO_USERNAME
PRIVATE_REPO_PASSWORD

example values for https://github.com/akihikokuroda/private repository are:

PRIVATE_REPO=https://github.com/akihikokuroda/private
PRIVATE_REPO_USERNAME=akihikokuroda
PRIVATE_REPO_PASSWORD=mypassword

@akihikokuroda akihikokuroda requested a review from a team as a code owner June 3, 2022 14:56
@akihikokuroda akihikokuroda force-pushed the privategittest branch 2 times, most recently from 00a6e75 to 6dcbcb4 Compare June 3, 2022 15:28
exdx
exdx reviewed Jun 6, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@exdx exdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, just some thoughts

Comment thread test/e2e/plain_provisioner_test.go Outdated
Comment thread test/e2e/plain_provisioner_test.go Outdated
Comment thread test/e2e/plain_provisioner_test.go Outdated
Comment thread test/e2e/plain_provisioner_test.go Outdated
Comment thread test/e2e/plain_provisioner_test.go Outdated
@akihikokuroda
e2e test private git repository
5fa4f5b 
Signed-off-by: akihikokuroda <akuroda@us.ibm.com>
@akihikokuroda
Copy link
Copy Markdown
Member Author

akihikokuroda commented Jun 6, 2022

Can I get help to set the 3 environment variables in the CI e2e? I don't have authority to set the secrets in the git action.

@exdx
Copy link
Copy Markdown
Contributor

exdx commented Jun 6, 2022

Can I get help to set the 3 environment variables in the CI e2e? I don't have authority to set the secrets in the git action.

I'll ping @joelanford as he has access

@akihikokuroda
Copy link
Copy Markdown
Member Author

akihikokuroda commented Jun 6, 2022

mypassword is a fake one. I can send him the real one if we use my private repository.

@akihikokuroda akihikokuroda merged commit 93d28fd into operator-framework:main Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@exdx exdx exdx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add e2e tests for sourcing from private git repositories

2 participants

@akihikokuroda @exdx