Skip to content
This repository was archived by the owner on Aug 12, 2024. It is now read-only.

git source: resolve branches/tags to commit hashes#542

Merged
joelanford merged 1 commit into
operator-framework:mainfrom
joelanford:resolve-git-commit-hash
Aug 31, 2022
Merged

git source: resolve branches/tags to commit hashes#542
joelanford merged 1 commit into
operator-framework:mainfrom
joelanford:resolve-git-commit-hash

Conversation

@joelanford
Copy link
Copy Markdown
Member

@joelanford joelanford commented Aug 31, 2022

Signed-off-by: Joe Lanford joe.lanford@gmail.com

Closes #394

@joelanford joelanford requested a review from a team as a code owner August 31, 2022 15:09
@joelanford
Copy link
Copy Markdown
Member Author

/hold

The fact that this passed without any tests needing to be changed isn't great. I'll go add a test to make sure we verify that the resolved source for git always contains a hash.

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 31, 2022
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@joelanford joelanford force-pushed the resolve-git-commit-hash branch from 56bdde4 to ed37175 Compare August 31, 2022 15:28
@joelanford
Copy link
Copy Markdown
Member Author

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 31, 2022
@joelanford joelanford merged commit 8ef6ccb into operator-framework:main Aug 31, 2022
@joelanford joelanford deleted the resolve-git-commit-hash branch August 31, 2022 17:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

improve git source implementation to return result with commit hash.

2 participants