This repository was archived by the owner on Aug 12, 2024. It is now read-only.
fix: avoid bundle update errors during deletion#562
Merged
joelanford merged 1 commit intoSep 21, 2022
Conversation
Our finalizer code is not integrated with our updater code, which results in two multiple update calls being made during a single reconcile when a bundle is deleted. The first call removes the finalizer, the second attempts to update the status. The second call fails because the bundle has been deleted in etcd after the finalizer is removed with the first call. This commit fully rips out the bundle updater and refactors things to ensure there’s never more than one status and bundle update per reconcile.
Member
Author
|
If folks think this direction is good, we should probably make a similar change for the bundle deployment controllers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our finalizer code is not integrated with our updater code, which results in two multiple update calls being made during a single reconcile when a bundle is deleted. The first call removes the finalizer, the second attempts to update the status. The second call fails because the bundle has been deleted in etcd after the finalizer is removed with the first call.
This commit fully rips out the bundle updater and refactors things to ensure there’s never more than one status and bundle update per reconcile.
Closes #566