Fixes `make lint` when run without args by m1kola · Pull Request #636 · operator-framework/rukpak

m1kola · 2023-06-14T15:42:34Z

In #631 I added an optional GOLANGCI_LINT_ARGS into make lint, but... When you run make lint you get this:

ERRO Running error: context loading failed: failed to load packages: package .: no go files to analyze

This should fix it.

Example runs:

make lint
make lint GOLANGCI_LINT_ARGS="--verbose"
make lint GOLANGCI_LINT_ARGS="--out-format github-actions"

Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>

Fixes make lint when run without args

c7e908b

Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 14, 2023

m1kola changed the title ~~Fixes make lint when run without args~~ Fixes make lint when run without args Jun 14, 2023

m1kola marked this pull request as ready for review June 14, 2023 15:57

m1kola requested a review from a team as a code owner June 14, 2023 15:57

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 14, 2023

everettraven approved these changes Jun 14, 2023

View reviewed changes

m1kola merged commit 4a597b7 into operator-framework:main Jun 14, 2023

m1kola deleted the make_lint_fix branch June 14, 2023 17:05

Provide feedback