Adding an ::OAuthClients::ConnectionManager to save, refresh and use OAuthClientTokens#10708
Merged
Merged
Conversation
wielinde
force-pushed
the
feature/file-links-oauth-connection-manager
branch
2 times, most recently
from
7c6b963 to
0454789
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
wielinde
force-pushed
the
feature/file-links-oauth-connection-manager
branch
from
0454789 to
746d56c
Compare
wielinde
force-pushed
the
feature/file-links-oauth-connection-manager
branch
from
746d56c to
5cbfc15
Compare
wielinde
changed the title
wielinde
force-pushed
the
feature/file-links-oauth-connection-manager
branch
3 times, most recently
from
bffd48b to
07e9ad0
Compare
wielinde
force-pushed
the
feature/file-links-oauth-connection-manager
branch
from
07e9ad0 to
fcf3f34
Compare
Kharonus
requested changes
Jun 8, 2022
Member
Kharonus
left a comment
Kharonus
left a comment
There was a problem hiding this comment.
Looks already quite great. Some open questions remain.
wielinde
force-pushed
the
feature/file-links-oauth-connection-manager
branch
from
10b7911 to
8a4c353
Compare
Kharonus
reviewed
Jun 13, 2022
Member
Kharonus
left a comment
Kharonus
left a comment
There was a problem hiding this comment.
New changes LGTM, just have a question popping out. And I will spend some time now to test it a bit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://community.openproject.org/wp/42578
OAuthClientTokencodeand requests the access token etc.OAuthClients::ConnectionManagertocode