Skip to content

[#51274] return correct parent id#14256

Merged
Kharonus merged 2 commits intodevfrom
bug/51274-direct-upload-to-empty-microsoft-drive-fails
Nov 29, 2023
Merged

[#51274] return correct parent id#14256
Kharonus merged 2 commits intodevfrom
bug/51274-direct-upload-to-empty-microsoft-drive-fails

Conversation

@Kharonus
Copy link
Copy Markdown
Member

@Kharonus Kharonus commented Nov 28, 2023

OP#51274

WAT?

  • one drive files query now returns real parent id when folder is empty, not the fake id like before

But ... WHY?

  • upload needs it for the prepare upload request, fake id led to error

- https://community.openproject.org/wp/51274
- one drive files query now returns real parent id when folder is empty
  - was a fake id before
- upload needs it for the prepare upload request, fake id led to error
@Kharonus Kharonus requested review from apfohl and mereghost November 28, 2023 10:09
@Kharonus Kharonus self-assigned this Nov 28, 2023
@Kharonus
Copy link
Copy Markdown
Member Author

I still need to update the VCR cassette.

Copy link
Copy Markdown
Contributor

@apfohl apfohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apfohl apfohl self-requested a review November 29, 2023 12:54
@Kharonus Kharonus merged commit f552765 into dev Nov 29, 2023
@Kharonus Kharonus deleted the bug/51274-direct-upload-to-empty-microsoft-drive-fails branch November 29, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants