implementation/60980 - Define restricted extension on work package journals for query safety

[akabiru]

AR association extensions ensure the restricted_visible scope is only visible on the work package journals association.

#18091 (comment)

[akabiru]

Oops- forgot to update the callers. 🏃🏾

[brunopagno]

The code changes look okay to me.

I do feel it's going to be more difficult for someone to find the restricted_visible method when someone wishes to debug it, but it's a bit of the nature of rails applications.

But it seems to have broken some specs, so we need to look into those before pushing forward

[akabiru]

The code changes look okay to me.

I do feel it's going to be more difficult for someone to find the restricted_visible method when someone wishes to debug it, but it's a bit of the nature of rails applications.

Cheers for the review- tbf, finding the association was already hard enough- and the journalization is encapsulated in one mixin, so hopefully that and the unit tests improve the odds of working it out. Definitely open to ideas on improving this 👍🏾

But it seems to have broken some specs, so we need to look into those before pushing forward

yeah, I blindly enabled frozen string literals - which broke some existing string mutations that I'd rather not mess with in this PR.

[ulferts]

Overall, I like this change @akabiru . To me, it reads nicer and appears to be more solid. Thanks for picking up my review feedback from before.

I added on point that I think could improve readability but as is the nature of such things, it is opinionated. So feel free to ignore it if you disagree.

[ulferts]

👍