Add i18n-js to OpenProject by schmidt · Pull Request #2 · opf/openproject

schmidt · 2012-12-12T10:20:09Z

Why client side I18n?

Client-side I18n is needed in a multitude of cases. At the moment, the two UI widgets in OpenProject, Calendar and Wiki Toolbar, use two separate I18n solutions. Every plugin, that is trying to do client-side I18n, will need to ship a third, fourth and fifth solution.

By introducing i18n-js into the OpenProject core, we can provide a single solution for future enhancements of the core and a generic solution for plugin authors.

Why i18n-js?

The plugin seems to be rather popular (Starred: > 500, Forked: > 100 atm).
It claims to support Rails 3 (not tested by me).
Its working principals are simple enough to take over development or replace it with something else, if need be.

This pull request is based on #52 in the finnlabs/chiliproject repository.

Impact on existing users

The install guide needs to be changed. The public/javascripts/i18n directory needs to writable, just like the public/plugin_assets.

Usage

I18n keys in the js scope will be available on the client side.

en:
  js:
    hello: Hello, World!

Especially for plugin authors, also js scopes in deeper nestings will be available

en:
  my_plugin:
    js:
      hello: Hello from plugin!

In your JS code, use the following commands:

I18n.t('js.hello'); // => "Hello, World!"
I18n.t('js.my_plugin.hello'); // => "Hello from plugin!"

* Limit i18n keys in JS to the 'js' scope to reduce payload * Update i18n gem to make i18n-js work with limited scopes * Exporting translations on server start and not on every request to save computing resources and avoid impact on response times * Configuring i18n-js to use the same fallbacks like the ruby part to ensure consistent behavior across languages * Removing rake tasks from Rakefile since (a) they do not belong there - should have been in lib/tasks - and (b) they are no longer needed, since the export happens at server start NB: public/javascripts/i18n needs to be writeable by the app server user.

The js lib does not expect the current locale to be the first fallback, but that's no good reason to change the original array, which is used by the ruby i18n.

apfelfabrik · 2013-01-22T10:46:16Z

Closing this one again, since referencing it somehow reopened it.

…a namespace attribute #2 This reverts commit e2b88cc.

prepare for release

Add mapping for migration squashing

…a namespace attribute #2 This reverts commit e2b88cc.

Feature/unwatch links

…a namespace attribute #2 This reverts commit e2b88cc.

* Don't use expect in retry_block It doesn't raise an exception, but only marks the example erroneous * Replace textile_link cuke * Replace wp search cuke with existing spec We only need to test for the href, no need to check that the page exists. * Also remove pagination cuke, its part of the search-spec [ci skip]

replace alias_method by super

FactoryGirl => FactoryBot (#6304)

# This is the 1st commit message: 项目成员信息添加专业，公司部门职位信息仅对管理员显示 # This is the commit message #2: 项目成员信息添加专业，公司部门职位信息仅对管理员显示

# This is the 1st commit message: yarn install # This is the commit message #2: gem and yarn upgrade # This is the commit message #3: Yarn to run Angular 17 # This is the commit message opf#4: gem and yarn upgrade

# This is the 1st commit message: Link to outside plugin. New labour_tracking modules openproject-labour_tracking update # This is the commit message #2: Move th_projects to outside. # This is the commit message #3: yarn upgrade # This is the commit message opf#4: gem and yarn upgrade # This is the commit message opf#5: yarn upgrade # This is the commit message opf#6: gem upgrade # This is the commit message opf#7: yarn upgrade # This is the commit message opf#8: yarn upgrade

# This is the 1st commit message: Link to outside plugin. New labour_tracking modules openproject-labour_tracking update # This is the commit message #2: Move th_projects to outside. # This is the commit message #3: yarn upgrade # This is the commit message opf#4: gem and yarn upgrade # This is the commit message opf#5: yarn upgrade # This is the commit message opf#6: gem upgrade # This is the commit message opf#7: yarn upgrade # This is the commit message opf#8: yarn upgrade # This is the commit message opf#9: gem and yarn upgrade # This is the commit message opf#10: yarn upgrade # This is the commit message opf#11: gem and yarn upgrade

…y_activity_spec Fix more non synchronous capybara expectations #2

Use an extension to fetch/commit data to OpenProject

GarstgerUnhold and others added 2 commits September 3, 2012 16:27

adds i18n-js gem providing us with easier access to translations in js

4511a4e

schmidt mentioned this pull request Dec 12, 2012

adds i18n-js gem providing us with easier access to translations in js apfelfabrik/finnlabs-chiliproject#52

Closed

Avoid messing up the fallbacks array

348321a

The js lib does not expect the current locale to be the first fallback, but that's no good reason to change the original array, which is used by the ruby i18n.

schmidt mentioned this pull request Dec 21, 2012

Replace Project Jump Box with select2 based version #8

Merged

linki pushed a commit that referenced this pull request Jan 8, 2013

fix a failing tests that depended on the correct fixtures #2

8415568

ghost assigned apfelfabrik Jan 22, 2013

apfelfabrik closed this Jan 22, 2013

linki added a commit that referenced this pull request Mar 3, 2014

let's try implementing tenant scoped attachments without introducing …

09e3bdf

…a namespace attribute #2 This reverts commit e2b88cc.

linki added a commit that referenced this pull request Mar 4, 2014

let's try implementing tenant scoped attachments without introducing …

da04b0f

…a namespace attribute #2 This reverts commit e2b88cc.

linki added a commit that referenced this pull request Mar 6, 2014

let's try implementing tenant scoped attachments without introducing …

037ef57

…a namespace attribute #2 This reverts commit e2b88cc.

linki added a commit that referenced this pull request Mar 21, 2014

let's try implementing tenant scoped attachments without introducing …

d2d9506

…a namespace attribute #2 This reverts commit e2b88cc.

linki added a commit that referenced this pull request Mar 28, 2014

let's try implementing tenant scoped attachments without introducing …

4b9ad35

…a namespace attribute #2 This reverts commit e2b88cc.

linki added a commit that referenced this pull request Apr 3, 2014

let's try implementing tenant scoped attachments without introducing …

c7e1f99

…a namespace attribute #2 This reverts commit e2b88cc.

linki added a commit that referenced this pull request May 2, 2014

let's try implementing tenant scoped attachments without introducing …

c159f3d

…a namespace attribute #2 This reverts commit e2b88cc.

linki added a commit that referenced this pull request May 12, 2014

let's try implementing tenant scoped attachments without introducing …

44fe467

…a namespace attribute #2 This reverts commit e2b88cc.

linki added a commit that referenced this pull request Jul 9, 2014

let's try implementing tenant scoped attachments without introducing …

a892ca1

…a namespace attribute #2 This reverts commit e2b88cc.

mfrister added a commit that referenced this pull request Jul 14, 2014

Merge pull request #2 from finnlabs/feature/prepare_for_release

08cfb63

prepare for release

myabc pushed a commit that referenced this pull request Jul 14, 2014

Merge pull request #2 from opf/add_mapping_for_migration_squashing

de1ec43

Add mapping for migration squashing

linki added a commit that referenced this pull request Jul 17, 2014

let's try implementing tenant scoped attachments without introducing …

7989d6c

…a namespace attribute #2 This reverts commit e2b88cc.

linki added a commit that referenced this pull request Jul 24, 2014

let's try implementing tenant scoped attachments without introducing …

1680807

…a namespace attribute #2 This reverts commit e2b88cc.

linki added a commit that referenced this pull request Jul 28, 2014

let's try implementing tenant scoped attachments without introducing …

85028aa

…a namespace attribute #2 This reverts commit e2b88cc.

linki added a commit that referenced this pull request Aug 4, 2014

let's try implementing tenant scoped attachments without introducing …

d9b4a1d

…a namespace attribute #2 This reverts commit e2b88cc.

linki added a commit that referenced this pull request Sep 5, 2014

let's try implementing tenant scoped attachments without introducing …

e9dd365

…a namespace attribute #2 This reverts commit e2b88cc.

NobodysNightmare pushed a commit that referenced this pull request Oct 1, 2014

Merge pull request #2 from opf/feature/unwatch-links

fc81dc4

Feature/unwatch links

NobodysNightmare pushed a commit that referenced this pull request Oct 1, 2014

Merge pull request #2 from opf/feature/unwatch-links

86aee98

Feature/unwatch links

linki added a commit that referenced this pull request Oct 13, 2014

let's try implementing tenant scoped attachments without introducing …

71883d4

…a namespace attribute #2 This reverts commit e2b88cc.

linki added a commit that referenced this pull request Oct 30, 2014

let's try implementing tenant scoped attachments without introducing …

8a87e65

…a namespace attribute #2 This reverts commit e2b88cc.

linki added a commit that referenced this pull request Oct 30, 2014

let's try implementing tenant scoped attachments without introducing …

07b798a

…a namespace attribute #2 This reverts commit e2b88cc.

ulferts added a commit that referenced this pull request Nov 15, 2018

Merge pull request #2 from opf/fix/replace_deprecations

61ee773

replace alias_method by super

ulferts added a commit that referenced this pull request Nov 15, 2018

Merge pull request #2 from opf/housekeeping/bump-factory-girl

f3624b7

FactoryGirl => FactoryBot (#6304)

crohr added a commit that referenced this pull request Nov 24, 2020

fix cache path #2

77841c2

dombesz mentioned this pull request Jul 7, 2022

[IMPLEMENTATION 41097] When adding a type to a project, add all configured custom fields to that project #10899

Merged

psatyal mentioned this pull request Jul 26, 2022

[42185] Issues when manually changing dates in datepicker #11034

Merged

dombesz added a commit that referenced this pull request Aug 9, 2022

Improvements #2

2cbf6f7

dombesz added a commit that referenced this pull request Aug 9, 2022

fixup! Improvements #2

0b06fdd

dombesz added a commit that referenced this pull request Aug 9, 2022

fixup! Improvements #2

bf6338a

dombesz added a commit that referenced this pull request Aug 9, 2022

fixup! Improvements #2

7cb7b34

dombesz added a commit that referenced this pull request Aug 9, 2022

fixup! Improvements #2

acccb3a

dombesz added a commit that referenced this pull request Aug 9, 2022

Improvements #2

051340e

dombesz added a commit that referenced this pull request Aug 11, 2022

Improvements #2

a8d2320

dombesz added a commit that referenced this pull request Aug 11, 2022

Revert 'Improvements #2'

5e96db4

dombesz added a commit that referenced this pull request Aug 11, 2022

Improvements #2

f56cf6b

dombesz added a commit that referenced this pull request Aug 11, 2022

Revert 'Improvements #2'

c84dccd

dombesz added a commit that referenced this pull request Aug 11, 2022

Improvements #2

8085206

dombesz added a commit that referenced this pull request Aug 11, 2022

Revert 'Improvements #2'

7362de0

dombesz added a commit that referenced this pull request Aug 15, 2022

Improvements #2

01fe2fa

dombesz added a commit that referenced this pull request Dec 7, 2022

[#44440] Issues with project selection on mobile #2

1267695

dombesz added a commit that referenced this pull request Dec 7, 2022

[#44440] Issues with project selection on mobile #2

46ddc62

oliverguenther pushed a commit that referenced this pull request Dec 7, 2022

[#44440] Issues with project selection on mobile #2

c640398

klaustopher added a commit that referenced this pull request Sep 20, 2023

Refactor tests to use new interface for user factory #2

fe4326c

dombesz added a commit that referenced this pull request Mar 7, 2025

Merge pull request #18194 from opf/bug/62032-fix-flickering-time_entr…

12cde1d

…y_activity_spec Fix more non synchronous capybara expectations #2

myabc mentioned this pull request Sep 2, 2025

[#66122] Lay foundations for Project Overview widgets with Turbo content #20033

Merged

5 tasks

akabiru pushed a commit that referenced this pull request Feb 11, 2026

Merge pull request #2 from opf/impl/66328-use-openproject-extension

defdb23

Use an extension to fetch/commit data to OpenProject

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add i18n-js to OpenProject#2

Add i18n-js to OpenProject#2
schmidt wants to merge 3 commits intoopf:masterfrom
finnlabs:feature/i18n-js

schmidt commented Dec 12, 2012

Uh oh!

apfelfabrik commented Jan 22, 2013

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Conversation

schmidt commented Dec 12, 2012

Why client side I18n?

Why i18n-js?

Impact on existing users

Usage

Uh oh!

apfelfabrik commented Jan 22, 2013

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants