Skip to content

Feature/64264 comment fields for project attributes #21452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
toy wants to merge 75 commits into
base: dev
Choose a base branch
from
Draft

Feature/64264 comment fields for project attributes #21452

toy wants to merge 75 commits into from

Conversation

@toy
Copy link
Contributor

@toy toy commented Dec 15, 2025

Ticket

https://community.openproject.org/wp/64264

What are you trying to accomplish?

Allow to comment project attributes

Screenshots

What approach did you choose and why?

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@toy toy force-pushed the feature/64264-comment-fields-for-project-attributes branch 3 times, most recently from d6d9bcd to 7b1dd29 Compare December 19, 2025 21:35
@toy toy force-pushed the feature/64264-comment-fields-for-project-attributes branch 3 times, most recently from d96b04a to 3ca06f4 Compare January 8, 2026 16:11
@toy toy mentioned this pull request Jan 8, 2026
Merged
@toy toy force-pushed the feature/64264-comment-fields-for-project-attributes branch from 3ca06f4 to 53e8534 Compare January 8, 2026 20:50
@toy toy mentioned this pull request Jan 9, 2026
Merged
@toy toy force-pushed the feature/64264-comment-fields-for-project-attributes branch 2 times, most recently from 22dc532 to 8fc8b9f Compare January 15, 2026 17:47
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-21452 January 15, 2026 18:22 Inactive
@toy toy force-pushed the feature/64264-comment-fields-for-project-attributes branch from 8fc8b9f to 406b2ff Compare January 19, 2026 19:44
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-21452 January 19, 2026 19:44 Inactive
@toy toy force-pushed the feature/64264-comment-fields-for-project-attributes branch from 406b2ff to 8fc1727 Compare January 20, 2026 20:04
@github-actions github-actions bot requested a deployment to gh-6899875-pr-21452 January 20, 2026 20:05 Pending
@toy toy force-pushed the feature/64264-comment-fields-for-project-attributes branch from 8fc1727 to fc6b5c8 Compare January 26, 2026 20:40
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-21452 January 26, 2026 20:40 Inactive
@toy toy force-pushed the feature/64264-comment-fields-for-project-attributes branch from fc6b5c8 to 26c4df2 Compare January 28, 2026 20:27
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-21452 January 28, 2026 20:27 Inactive
@toy toy force-pushed the feature/64264-comment-fields-for-project-attributes branch from 26c4df2 to 0e1b24b Compare January 29, 2026 13:19
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-21452 January 29, 2026 13:20 Inactive
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-21452 January 29, 2026 21:20 Inactive
@toy toy force-pushed the feature/64264-comment-fields-for-project-attributes branch from ad81a62 to c7956ed Compare February 2, 2026 20:56
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-21452 February 2, 2026 23:18 Inactive
toy added 18 commits February 5, 2026 17:26
@toy
move admin_only check of custom field related activity to the query
696ebc3 
This should be more efficient and will ensure "The changes were
retracted" message shown when all changes are hidden
@toy
allow showing journal diff for deleted custom fields
9332ed5
@toy
delegate CustomField#can_have_comment? instead of defining
34061ad
@toy
adapt changes from ac1f346 and 4ab26f5 to custom comment journaling
49a9274
@toy
add CustomField#comment_attribute_name
4d5da33
@toy
allow custom comment attributes through project update contract
85075f6
@toy
refactor checking if field can be diffed
a5310f8
@toy
transform keys to strings instead of converting to hash with indiffer…
e75aa66 
…ent access
@toy
field for custom comment
20efa8f
@toy
extract DialogComponent for shared behaviour between Edit and Show di…
e691039 
…alogs
@toy
action and permission for dialog to show value'n'comment
116a31e
@toy
permit custom comments for projects
1f9fd3f
@toy
inherit item component from show component allowing to render comment
9e73a9e
@toy
move configuration for ability to have custom comments to acts_as_cus…
6937f1d 
…tomizable
@toy
move adding custom_comments relation to acts_as_customizable and mark…
e1d58c1 
… for autosave
@toy
allow to assign comments in a way similar to values
707846c
@toy
include acts as customizable methods at start of call
8e3055d
@toy
return changes to comments from custom_field_changes and changed_with…
d275983 
…_custom_fields
@toy toy force-pushed the feature/64264-comment-fields-for-project-attributes branch from c545361 to d275983 Compare February 5, 2026 16:30
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-21452 February 5, 2026 16:31 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

pullpreview

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@toy @lindenthal