Skip to content

Conversation

@myabc
Copy link
Contributor

@myabc myabc commented Jan 15, 2026

Ticket

https://community.openproject.org/wp/70573

What are you trying to accomplish?

  • Fixes invalid HTML in top menu.
  • Renders top and left menu inside semantic navigation sections (<nav> elements).
  • Replaces headings with accessible names (aria-labels) - headings (particularly <h1> may confuse screen-readers about the structure of the page)

Screenshots

No visual changes.

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@myabc myabc force-pushed the bug/70573-axe-accessibility-error-invalid-list-structure branch from e9f215f to 22865c3 Compare January 16, 2026 02:21
For symmetry with top menu (see f63e644).
@myabc myabc force-pushed the bug/70573-axe-accessibility-error-invalid-list-structure branch from de4860b to f42ad23 Compare January 16, 2026 02:26
@myabc myabc marked this pull request as ready for review January 16, 2026 02:44
Copilot AI review requested due to automatic review settings January 16, 2026 02:44
@github-actions
Copy link

Caution

The provided work package version does not match the core version

Details:

Please make sure that:

  • The work package version OR your pull request target branch is correct

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes AXe accessibility errors related to invalid list structure in the top menu and main menu. The changes replace semantically incorrect HTML with proper navigation elements and ARIA labels.

Changes:

  • Changed top menu wrapper from <ul> to <nav> with proper aria-label
  • Removed redundant <h1 class="sr-only"> elements for top menu and main menu
  • Changed main menu wrapper from <div> to <nav> with aria-label for proper semantic structure

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
lib/redmine/menu_manager/top_menu_helper.rb Changed render_top_menu_left to use <nav> instead of <ul> and added aria-label for accessibility
app/views/layouts/base.html.erb Removed redundant screen-reader-only headings and changed main menu wrapper to semantic <nav> element with aria-label

@myabc myabc changed the base branch from dev to release/17.0 January 16, 2026 02:48
@myabc myabc merged commit 39d31b3 into release/17.0 Jan 21, 2026
25 of 28 checks passed
@myabc myabc deleted the bug/70573-axe-accessibility-error-invalid-list-structure branch January 21, 2026 14:15
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Development

Successfully merging this pull request may close these issues.

3 participants