-
Notifications
You must be signed in to change notification settings - Fork 3.1k
[#70573] Fix AXe Accessibility error: invalid list structure #21694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#70573] Fix AXe Accessibility error: invalid list structure #21694
Conversation
Uses a semantic navigation section element. https://community.openproject.org/work_packages/70573
Replaces existing `sr-only` heading.
e9f215f to
22865c3
Compare
For symmetry with top menu (see f63e644).
de4860b to
f42ad23
Compare
|
Caution The provided work package version does not match the core version Details:
Please make sure that:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request fixes AXe accessibility errors related to invalid list structure in the top menu and main menu. The changes replace semantically incorrect HTML with proper navigation elements and ARIA labels.
Changes:
- Changed top menu wrapper from
<ul>to<nav>with properaria-label - Removed redundant
<h1 class="sr-only">elements for top menu and main menu - Changed main menu wrapper from
<div>to<nav>witharia-labelfor proper semantic structure
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/redmine/menu_manager/top_menu_helper.rb | Changed render_top_menu_left to use <nav> instead of <ul> and added aria-label for accessibility |
| app/views/layouts/base.html.erb | Removed redundant screen-reader-only headings and changed main menu wrapper to semantic <nav> element with aria-label |
Ticket
https://community.openproject.org/wp/70573
What are you trying to accomplish?
<nav>elements).aria-labels) - headings (particularly<h1>may confuse screen-readers about the structure of the page)Screenshots
No visual changes.
Merge checklist