Attempt to fix flaky Backlogs feature specs#21934
Merged
Merged
Conversation
myabc
changed the title
myabc
force-pushed
the
fix/backlogs-flickering-features
branch
from
4281460 to
1d6647f
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts Backlogs feature specs to reduce flickering/flakiness by changing how the “details view” navigation is synchronized and by switching some specs away from Selenium-driven execution.
Changes:
- Moved the “details view” current-path assertion into the shared
within_details_viewhelper and removed a turbo-framecompletewait. - Updated Backlogs feature specs to run with the default
:jsdriver (Cuprite) by removing:selenium/ explicit Firefox driver metadata. - Refactored/renamed Backlogs stories feature scenarios into clearer, separate examples.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
modules/backlogs/spec/support/pages/backlogs.rb |
Removes a flaky turbo-frame readiness wait and centralizes the details-view URL assertion in within_details_view. |
modules/backlogs/spec/features/stories_in_backlog_spec.rb |
Drops :selenium metadata (switching to default :js driver) and restructures scenarios into multiple it blocks. |
modules/backlogs/spec/features/backlogs/create_story_spec.rb |
Drops :selenium and the explicit Firefox driver previously used for a regression-focused run. |
myabc
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
N/A
What are you trying to accomplish?
Fix flaky spec
modules/backlogs/spec/features/stories_in_backlog_spec.rb:144which was failing in https://github.com/opf/openproject/actions/runs/21831004728/job/62989007830What approach did you choose and why?
within_details_viewhelper and removed a turbo-frame complete wait.:jsdriver (Cuprite) by removing:selenium/ explicit Firefox driver metadata.Merge checklist