Skip to content

[#72773] Rework Permission Renamer#22172

Merged
dombesz merged 1 commit intodevfrom
bug/72773-rework-permission-renamer
Mar 4, 2026
Merged

[#72773] Rework Permission Renamer#22172
dombesz merged 1 commit intodevfrom
bug/72773-rework-permission-renamer

Conversation

@dombesz
Copy link
Copy Markdown
Contributor

@dombesz dombesz commented Mar 3, 2026

Ticket

https://community.openproject.org/work_packages/72773

What are you trying to accomplish?

Follow up on a discussion here #22001 (comment)

What approach did you choose and why?

Use the Migration::MigrationUtils::PermissionAdder to implement the rename method, this way it will automatically ignore duplicate permissions.

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

Base automatically changed from implementation/71253-migrate-and-rework-sprint-permissions to dev March 3, 2026 17:12
Copy link
Copy Markdown
Contributor

@ulferts ulferts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only feedback I have, @dombesz is not specific to this PR but to the Agile-migration. So feel free to merge and address my comment in a separate PR.

Comment thread db/migrate/20260212145213_migrate_backlogs_permissions.rb
@dombesz dombesz merged commit aca4a65 into dev Mar 4, 2026
10 of 11 checks passed
@dombesz dombesz deleted the bug/72773-rework-permission-renamer branch March 4, 2026 18:11
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants