Skip to content

Add UI for internal wiki provider#23528

Merged
NobodysNightmare merged 3 commits into
devfrom
configure-internal-wiki
Jun 9, 2026
Merged

Add UI for internal wiki provider#23528
NobodysNightmare merged 3 commits into
devfrom
configure-internal-wiki

Conversation

@NobodysNightmare

Copy link
Copy Markdown
Contributor

Every OpenProject instance is supposed to have one internal wiki provider.
@NobodysNightmare NobodysNightmare requested a review from a team June 3, 2026 07:28
@NobodysNightmare NobodysNightmare force-pushed the configure-internal-wiki branch from c8d3422 to 48ba2d5 Compare June 3, 2026 07:31
@Kharonus

Kharonus commented Jun 8, 2026

Copy link
Copy Markdown
Member

First UI testing:

image

The parent menu item should be "Wiki" or "Wikis", not "Wiki providers".

The breadcrumbs do not reflect the structure. They should list the parent and redirect to the same page, that would open, when I directly click on the parent menu item.

module Wikis
class InternalProviderSeeder < Seeder
def seed_data!
::Wikis::InternalProvider.create!(universal_identifier: "internal", name: "internal", enabled: true)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ I wondered, if we should give the internal wiki a universal identifier that represents more the absence of a value. Like the "NULL" uuid: 00000000-0000-0000-0000-000000000000

WDYT?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the one hand, I don't think that we need to represent the absence of a value. The internal wiki can have an identifier that it's findable by. Why not?

On the other hand, I'd find it weird and arbitrary that we set a useless UUID for a field that doesn't care about the exact format of its data. We could use 0 the same way that we could use 00000000-0000-0000-0000-000000000000 or file_not_found.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, all fine. The word internal just didn't catch me. :D But leave it, if there is no pain felt on your side.

Comment thread modules/wikis/lib/open_project/wikis/engine.rb Outdated
Making them consistent with the internal wiki view.
Essentially we have a two-level navigation on the left
and that needs to be reflected in the breadscrumbs everywhere.
@NobodysNightmare NobodysNightmare force-pushed the configure-internal-wiki branch from 48ba2d5 to 96e1f09 Compare June 9, 2026 06:16
@NobodysNightmare NobodysNightmare requested a review from Kharonus June 9, 2026 06:16
@NobodysNightmare NobodysNightmare merged commit e6d02ca into dev Jun 9, 2026
17 checks passed
@NobodysNightmare NobodysNightmare deleted the configure-internal-wiki branch June 9, 2026 09:22
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants