Skip to content

Added basic support for TypeScript #3947

Merged
furinvader merged 2 commits into
opf:release/5.0from
oliverguenther:feature/typescript
Dec 17, 2015
Merged

Added basic support for TypeScript #3947
furinvader merged 2 commits into
opf:release/5.0from
oliverguenther:feature/typescript

Conversation

@oliverguenther
Copy link
Copy Markdown
Member

This supersedes #3735 with fixed npm-shrinkwrap.json.

/cc @furinvader, @romanroe: You should clarifiy the role of typings/tsd.d.ts, since its specified in the config, but excluded from Git.

Also, please add some kind of documentation before merging this.

@oliverguenther oliverguenther added this to the 5.1 milestone Dec 1, 2015
@TeatroIO
Copy link
Copy Markdown

TeatroIO commented Dec 1, 2015

I've prepared a stage to preview changes. Open stage or view logs.

@oliverguenther
Copy link
Copy Markdown
Member Author

@ulferts
Copy link
Copy Markdown
Contributor

ulferts commented Dec 2, 2015

Copying my comment from #3735:

However, instead of "npm install" I had to do
npm install --save typescript
npm install --save ts-loader

Would that also be necessary for users wanting to install OpenProject after this is merged? We would then have to update our testing and delivery pipeline.

@oliverguenther
Copy link
Copy Markdown
Member Author

No, --save is only required to introduce the dependency into package.json. npm i(nstall) is sufficient on the user side of things.

@romanroe
Copy link
Copy Markdown
Contributor

romanroe commented Dec 8, 2015

The file typings/tsd.d.ts gets generated with tsd install and is required for the build. The content is based on tsd.json.

I am a bit lost between https://community.openproject.org/work_packages/21913/activity and this pull request. What can I do to help with the TypeScript integration?

furinvader added a commit that referenced this pull request Dec 17, 2015
@furinvader furinvader merged commit 4e704c0 into opf:release/5.0 Dec 17, 2015
@oliverguenther oliverguenther deleted the feature/typescript branch January 6, 2016 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants