Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added basic support for TypeScript #3947

Merged
merged 2 commits into from Dec 17, 2015

Conversation

@oliverguenther
Copy link
Member

@oliverguenther oliverguenther commented Dec 1, 2015

This supersedes #3735 with fixed npm-shrinkwrap.json.

/cc @furinvader, @romanroe: You should clarifiy the role of typings/tsd.d.ts, since its specified in the config, but excluded from Git.

Also, please add some kind of documentation before merging this.

@TeatroIO
Copy link

@TeatroIO TeatroIO commented Dec 1, 2015

I've prepared a stage to preview changes. Open stage or view logs.

@ulferts
Copy link
Contributor

@ulferts ulferts commented Dec 2, 2015

Copying my comment from #3735:

However, instead of "npm install" I had to do
npm install --save typescript
npm install --save ts-loader

Would that also be necessary for users wanting to install OpenProject after this is merged? We would then have to update our testing and delivery pipeline.

@oliverguenther
Copy link
Member Author

@oliverguenther oliverguenther commented Dec 2, 2015

No, --save is only required to introduce the dependency into package.json. npm i(nstall) is sufficient on the user side of things.

@romanroe
Copy link
Collaborator

@romanroe romanroe commented Dec 8, 2015

The file typings/tsd.d.ts gets generated with tsd install and is required for the build. The content is based on tsd.json.

I am a bit lost between https://community.openproject.org/work_packages/21913/activity and this pull request. What can I do to help with the TypeScript integration?

furinvader added a commit that referenced this pull request Dec 17, 2015
Added basic support for TypeScript
@furinvader furinvader merged commit 4e704c0 into opf:release/5.0 Dec 17, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@oliverguenther oliverguenther deleted the oliverguenther:feature/typescript branch Jan 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.