Handle missing viewpoint_names and make snapshot filename unique#8197
Merged
Handle missing viewpoint_names and make snapshot filename unique#8197
Conversation
Frontend created snapshots may not have a `viewpoint_name` property, which is currently being used in the XML exporter. It's better to export viewpoints with a unique name however, so I suggest we use the viewpoint UUID + .xml for the XML data, and UUID + .png (or whatever extension) for the associated snapshot.
wielinde
reviewed
Mar 25, 2020
Member
wielinde
left a comment
wielinde
left a comment
There was a problem hiding this comment.
Thank you for this PR. Please see my inline comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Frontend created snapshots may not have a
viewpoint_nameproperty, which is currently being used in the XML exporter.It's better to export viewpoints with a unique name however, so I suggest we use the viewpoint UUID + .xml for the XML data, and UUID + .png (or whatever extension) for the associated snapshot.