Merged
Conversation
oliverguenther
force-pushed
the
impl/38708/workdays
branch
2 times, most recently
from
e836457 to
20716a7
Compare
ulferts
requested changes
Oct 1, 2021
Contributor
ulferts
left a comment
ulferts
left a comment
There was a problem hiding this comment.
Mostly just nitpicking in the code.
Continuing nitpicking, the margins
- between the heading and the first checkbox
- between the checkboxes
- to the left of the checkboxes (although I don't understand where these should be indented)
are way smaller than in the specification. Those styling changes can also be done in a separate PR where we give the whole page another polish.
The functionality itself is looking solid.
We don't use now() so timecop can be used
oliverguenther
force-pushed
the
impl/38708/workdays
branch
from
bb4f96f to
11b6df7
Compare
Member
Author
|
I fixed everything except for the margins, as I'd also vote for a separate PR that does the styling as in here I just want to use the existing components |
ulferts
approved these changes
Oct 4, 2021
akabiru
added a commit
that referenced
this pull request
Apr 15, 2026
The idLabel getter was bypassing formattedId entirely, always rendering the numeric PK with a # prefix. In semantic mode this showed #9720 instead of KSTP-1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OP#38708