Skip to content

[#650] 마케팅 버전을 1.3으로 설정한다#652

Merged
opficdev merged 4 commits into
developfrom
chore/#650-marketing1.3
Jun 27, 2026
Merged

[#650] 마케팅 버전을 1.3으로 설정한다#652
opficdev merged 4 commits into
developfrom
chore/#650-marketing1.3

Conversation

@opficdev

@opficdev opficdev commented Jun 27, 2026

Copy link
Copy Markdown
Owner

🔗 연관된 이슈

🎯 의도

  • 앱 배포용 마케팅 버전을 1.3으로 갱신하고 설정 화면의 앱 버전 표시가 마케팅 버전과 빌드 번호를 함께 보여주도록 정리

📝 작업 내용

📌 요약

  • MARKETING_VERSION1.3으로 변경
  • 설정 화면의 앱 버전 표시를 CFBundleShortVersionString.CFBundleVersion 형식으로 변경

🔍 상세

  • Application/Shared/Version.xcconfig의 마케팅 버전을 1.2.6에서 1.3으로 수정
  • SettingsFeature.State에서 앱 버전 값을 계산할 때 CFBundleShortVersionStringCFBundleVersion을 함께 읽도록 변경
  • 비어 있는 버전 값은 제외하고 유효한 값만 .으로 조합하도록 처리

📸 영상 / 이미지 (Optional)

없음

@opficdev opficdev self-assigned this Jun 27, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the marketing version to 1.3 and refactors the app version retrieval in SettingsFeature.swift to combine both the marketing version and the build number. The reviewer suggests formatting the combined version string as 'Marketing Version (Build Number)' (e.g., '1.3 (1)') instead of joining them with a dot, which could lead users to mistake the build number for a patch version.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@opficdev opficdev merged commit 3ecaf4e into develop Jun 27, 2026
6 checks passed
@opficdev opficdev deleted the chore/#650-marketing1.3 branch June 27, 2026 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

마케팅 버전을 1.3으로 설정한다

1 participant