[#651] REST API 실패 응답의 status code와 body를 Crashlytics에 기록하도록 개선한다#653
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request integrates the Nexa module into FirebaseCrashlyticsHelper to extract and include REST error metadata (status code and error message) from NXError instances in Crashlytics reports. The reviewer suggested using Swift's native merge(_:uniquingKeysWith:) method instead of iterating with forEach to merge dictionaries more declaratively.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
🎯 의도
REST API 실패 시 Crashlytics non-fatal 로그에서 서버 응답의 status code와 에러 메시지를 확인할 수 있도록 개선
📝 작업 내용
📌 요약
FirebaseCrashlyticsHelper에서NXError기반 REST 실패 응답 메타데이터 추출userInfo에restStatusCode,restErrorMessage추가🔍 상세
NXError.invalidStatus,NXError.server에서 HTTP status code와 response data 추출message값을 디코딩해 Crashlytics 메타데이터로 기록record호출부와FunctionAPIClient에러 전파 흐름은 유지📸 영상 / 이미지 (Optional)