[#662] 공용 UI 요소를 Shared 모듈로 분리한다#674
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
이번 PR에서는 공통 프레젠테이션 컴포넌트인 LoadingView와 NavigationRouter를 별도의 프레임워크인 PresentationShared로 분리하여 모듈화를 진행했습니다. 이를 위해 PresentationShared 프로젝트를 신설하고 Workspace에 등록하였으며, 기존 Presentation 모듈 내의 여러 뷰 파일에서 PresentationShared를 임포트하도록 수정했습니다. 또한 외부 모듈에서 접근할 수 있도록 공유 컴포넌트들의 접근 제어자를 public으로 변경했습니다. 변경 사항에 대해 추가적인 피드백은 없습니다.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
opficdev
force-pushed
the
chore/#662-shared-presentation-module
branch
from
10ff0ad to
a6f32b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
🎯 의도
📝 작업 내용
📌 요약
PresentationShared하위 모듈 추가LoadingView,NavigationRouter를PresentationShared로 이동🔍 상세
PresentationShared를Application/Presentation/Shared하위 framework target으로 구성Presentation이PresentationShared를 참조하도록 의존성 연결LoadingFeature,MainTab은 이번 범위에서 제외해 TCA 의존성과 shell routing 경계 변경을 보류PresentationSharedimport 추가📸 영상 / 이미지 (Optional)