Conversation
…ce 시나리오 제거 - Combine 제거 - 데이터는 기존에도 함수의 반환 값을 받아 연동했기 때문에 문제 X
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
이 PR은 WebPageImageStore를 actor로 전환하여 동시성을 개선하고, Apple 로그인 과정에 상태 체크 로직을 도입하여 중복 요청을 방지했습니다. 또한 파일 시스템 작업들을 유틸리티 우선순위의 별도 태스크로 분리했습니다. 리뷰 피드백으로는 WebPageImageStore에서 제거된 CurrentValueSubject로 인해 발생할 수 있는 실시간 크기 모니터링 기능의 회귀 가능성을 지적하며, AsyncStream 도입을 제안했습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
📝 작업 내용
📌 요약
Task.detached(priority: .utility)기반 백그라운드 실행 분리🔍 상세
WebPageImageStore공개 API의async전환FileManager의@Sendable클로저 캡처 회피WebPageMetadataService,WebPageImageRepositoryImpl,WebPageRepositoryImpl의 저장소 API 호출 정리AppleSignInDelegate의@MainActordelegate 유지AppleAuthenticationService의 continuation 소유권 및 완료 처리 단일화SocialLoginError.authenticationAlreadyInProgress추가📸 영상 / 이미지 (Optional)