[#510] TCA 라이브러리 의존성을 추가한다#540
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
이번 풀 리퀘스트는 기존 SwiftLint 빌드 툴 플러그인 방식을 제거하고, 커스텀 빌드 스크립트(DevLogScripts.swiftLint)를 통해 SwiftLint를 실행하도록 전환하며, 이를 위해 사용자 스크립트 샌드박싱(ENABLE_USER_SCRIPT_SANDBOXING) 설정을 비활성화합니다. 또한 ComposableArchitecture 패키지 의존성이 새롭게 추가되었습니다. 피드백으로는 특정 디렉토리 내의 모든 Swift 파일에 대해 루프를 돌며 swiftlint 프로세스를 개별적으로 실행하는 방식이 빌드 성능을 저하시킬 수 있으므로, 파일 경로들을 배열로 수집하여 단 한 번만 프로세스를 실행하도록 개선하라는 의견이 제시되었습니다.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
🎯 의도
📝 작업 내용
📌 요약
🔍 상세
/opt/homebrew/bin,/usr/local/binPATH 명시Sources는 각 target의Sources/.swiftlint.yml기반으로 lint 수행Tests는 각 test target의Tests/.swiftlint.yml기반으로 lint 수행Tests/.swiftlint.yml은 루트.swiftlint-tests.yml을 parent config로 사용ENABLE_USER_SCRIPT_SANDBOXING비활성화📸 영상 / 이미지 (Optional)