[#553] compact ui에서 토스트가 탭바와 너무 가깝게 뜨는 현상을 해결한다#555
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces dynamic bottom inset adjustment for Toast overlays based on the visible tab bar height. Feedback was provided on the visibleTabBarHeight property in UIViewController, pointing out that checking self as? UITabBarController first ignores presented view controllers (modals), leading to incorrect layout. A refactored implementation was suggested to traverse to the top-most presented view controller first and eliminate redundant checks.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
🔗 연관된 이슈
🎯 의도
📝 작업 내용
📌 요약
ToastHostModifier에서 현재 key window 기준 tab bar 높이 계산 추가safeAreaInsets.bottom을 제외한 값을 토스트 하단 padding으로 반영visibleTabBarHeighthelper 추가로 tab bar 높이 탐색 처리🔍 상세
UIApplication.shared.connectedScenes를 순회해 현재isKeyWindow인 window 탐색rootViewController기준으로 visible tab bar 높이 계산safeAreaInsets.bottom을 제외한 값만padding(.bottom)에 반영ToastPresenter, 토스트 애니메이션, dismiss 흐름은 기존 로직 유지📸 영상 / 이미지 (Optional)