Skip to content

[#553] compact ui에서 토스트가 탭바와 너무 가깝게 뜨는 현상을 해결한다#555

Merged
opficdev merged 2 commits into
developfrom
fix/#553-toast
Jun 7, 2026
Merged

[#553] compact ui에서 토스트가 탭바와 너무 가깝게 뜨는 현상을 해결한다#555
opficdev merged 2 commits into
developfrom
fix/#553-toast

Conversation

@opficdev
Copy link
Copy Markdown
Owner

@opficdev opficdev commented Jun 7, 2026

🔗 연관된 이슈

🎯 의도

  • compact 레이아웃에서 토스트가 탭바 바로 위에 붙어 보이던 문제 해결 목적
  • 기존 토스트 표시 구조는 유지하면서 하단 위치만 최소 범위로 보정 목적

📝 작업 내용

📌 요약

  • ToastHostModifier에서 현재 key window 기준 tab bar 높이 계산 추가
  • safeAreaInsets.bottom을 제외한 값을 토스트 하단 padding으로 반영
  • visibleTabBarHeight helper 추가로 tab bar 높이 탐색 처리

🔍 상세

  • UIApplication.shared.connectedScenes를 순회해 현재 isKeyWindow인 window 탐색
  • 해당 window의 rootViewController 기준으로 visible tab bar 높이 계산
  • 계산한 높이에서 safeAreaInsets.bottom을 제외한 값만 padding(.bottom)에 반영
  • ToastPresenter, 토스트 애니메이션, dismiss 흐름은 기존 로직 유지

📸 영상 / 이미지 (Optional)

@opficdev opficdev self-assigned this Jun 7, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces dynamic bottom inset adjustment for Toast overlays based on the visible tab bar height. Feedback was provided on the visibleTabBarHeight property in UIViewController, pointing out that checking self as? UITabBarController first ignores presented view controllers (modals), leading to incorrect layout. A refactored implementation was suggested to traverse to the top-most presented view controller first and eliminate redundant checks.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread Application/DevLogPresentation/Sources/Common/Component/Toast.swift
@opficdev opficdev merged commit 13103a3 into develop Jun 7, 2026
5 checks passed
@opficdev opficdev deleted the fix/#553-toast branch June 7, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

compact ui에서 토스트가 탭바와 너무 가깝게 뜨는 현상을 해결한다

1 participant