Reduce status bar icon width on the Mac Menu Bar#80
Merged
Conversation
Contributor
|
야, 상태 표시줄 아이콘 너비가 내용물에 따라 늘어나게 하고 로딩 뺑뺑이(회전) 애니메이션 추가했네.
근데 이건 맛보기 리뷰다. 버그랑 보안까지 탈탈 털어주는 딥한 리뷰 원하면 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
StatusBarControllerrespond to intrinsic size changes so the menu bar item resizes automatically when its icon view content changesStatusBarIconViewto defer text display, use monospaced/different fonts based on state, and animate the spinning dollar icon while loadingTesting: