Align menu bar usage metrics with weekly priority#81
Conversation
|
맥 메뉴 막대 아이콘에 표시될 사용량 메트릭의 우선순위(주간 > 월간...)를 재정립하고, 아이콘 전용/고정/알림 우선 모드 등 다양한 디스플레이 옵션과 중요 알림 배지(Red Dot) 기능을 추가했습니다. Code Review (Preview)
이것은 짧은 미리보기입니다. 버그 탐지와 보안 점검을 포함한 전체 코드 리뷰를 원하시면 |
|
@opgginc/op-gg-ai-devops |
✅ AI Code Review Completed
리뷰 올렸고 핵심 이슈 3건 남겼다. CI는 전부 통과했고, 인라인 제안 확인하면 됨. |
![op-gg-ai-devops[bot]](https://avatars.githubusercontent.com/in/2680015?s=60&v=4){kind=small}
There was a problem hiding this comment.
🤖 OP.GG DevOps AI Code Review
요약
Recent Quota Change Only표기가used없이 퍼센트만 보여서 규칙(used/left 명시) 위반이라 모호함.- Total Cost가 0일 때
$0.00표시로 바뀌어 디자인 결정(0이면OC Bar)과 불일치. - 새 Status Bar Options 메뉴(표시 모드/배지/이름 표시) 설명이 README에 누락됨.
테스트
npm installnpm run lint:actions
CI/CD Status
- ✅ CI/Lint/Test/Build/CodeQL 모두 성공
누군가 이 PR 브랜치에 커밋을 다시 push하면, 이 봇이 전체 PR을 자동으로 다시 리뷰함.
PR 코멘트에 @opgginc/op-gg-ai-devops 멘션해도 다시 리뷰함. 예시:
@opgginc/op-gg-ai-devops Status Bar Options 문서 추가 누락 체크해줘@opgginc/op-gg-ai-devops Recent Quota Change Only 표시 규칙 재검토해줘@opgginc/op-gg-ai-devops 0일 때 OC Bar 표기 동작 확인해줘
|
@opgginc/op-gg-ai-devops PR updated: please review when convenient. Commit: e4546e6 |
✅ AI Code Review CompletedReview finished and inline comments are posted. CI/Test/Build are still running for this commit, so re-check once they complete. Local tests were not run because the Xcode toolchain is unavailable in this environment.
Reviewed with |
There was a problem hiding this comment.
🤖 OP.GG DevOps AI Code Review
Summary
- Pinned provider display can drift when the pinned provider is disabled, leading to UI mismatch between menu selection and status bar text.
- Critical badge logic ignores over-100% usage, so a provider over quota may not show the badge.
CI/CD Status
- ⏳ CI/Test/Build are still running for this commit.
Tests
- Not run (Xcode toolchain not available in this environment).
- Dependencies not installed; SwiftPM/Xcode resolution not available here, so results may be incomplete.
Review Language
If you want a default review language, add it to AGENTS.md. Example: Default review language: English.
…ail Percents Introduce consistent naming conventions: - Status Bar Percent: single representative percentage in macOS top status bar - Dropdown Detail Percents: multi-window percentages in dropdown menu Update both AGENTS-design-decisions.md and README.md to use new terminology. Co-authored-by: opencode <no-reply@opencode.ai>
|
@opgginc/op-gg-ai-devops Please review this PR. |
✅ AI Code Review CompletedReview posted with one inline suggestion about status-bar priority across accounts. CI/Test/Build are still running; local tests were not run due to missing Xcode. Dependency installation was skipped because no lockfiles were found.
Reviewed with |
There was a problem hiding this comment.
🤖 OP.GG DevOps AI Code Review
Summary
- Status-bar percent priority is currently applied per account, which can surface a lower-priority window (hourly) even when a higher-priority window (weekly) exists on another account. This breaks the fixed priority rule for the status bar.
CI/CD Status
- ⏳ CI/Test/Build are still running for this commit.
Tests
- Not run (Xcode toolchain not available in this environment).
- Dependencies: no lockfiles detected, install skipped.
Review Language
If you want a default review language, add it to AGENTS.md. Example: Default review language: English.
…r critical badge - selectedPinnedProvider() now returns nil when pinned provider is disabled instead of silently falling back to first enabled provider, preventing UI mismatch between menu selection and status bar display - usagePercentsForMostUsed() now clamps values to 100% instead of filtering them out, so over-quota providers still trigger critical badge detection Co-authored-by: opencode <no-reply@opencode.ai>
|
@opgginc/op-gg-ai-devops Fixed both unresolved threads. Please re-review. |
✅ AI Code Review CompletedReview posted with one priority issue about status bar percent priority across accounts; see the inline suggestion. CI is still running, and SwiftPM resolution could not run here because xcodebuild is unavailable. Reviewed with |
There was a problem hiding this comment.
🤖 OP.GG DevOps AI Code Review
Summary
- Status Bar Percent priority is still applied per-account, so a lower-priority window can win when another account has higher %; this breaks the fixed priority rule.
CI/CD Status
- ⏳ CI/Test/Build are still running for this commit.
Tests
npm install --no-package-locknpm run lint:actions- SwiftPM dependency resolution not run (xcodebuild not available in this environment).
Review Language
If you want a default review language, add it to AGENTS.md. Example: Default review language: English.
Per IMMUTABLE design rule, the status bar priority (Weekly → Monthly → Daily → Hourly → fallback) must be applied globally across all accounts, not per-account then maxed. Added preferredUsedPercentForStatusBar() that collects all candidates from all accounts first, then picks the highest priority window globally. Removed dead usedPercentsForStatusBar(). Co-authored-by: opencode <no-reply@opencode.ai>
|
✅ Fixed. Added |
|
✅ Fixed in the same commit as the above thread. The root cause was identical — per-account priority selection then cross-account max(). Now both |
|
@opgginc/op-gg-ai-devops Please re-review. Fixed cross-account priority aggregation — now applies global priority rule across all accounts before selecting max percent. |
✅ AI Code Review CompletedReview finished. Check the PR for inline comments. 📋 View Logs | 🤖 Model: |
- StatusBarController.swift 내 모든 퍼센트 출력에서 'used' 문자열 제거 - AGENTS-design-decisions.md에 공간이 협소할 경우 퍼센트 단독 표시 허용 규칙 추가 - 상태 표시줄 텍스트를 더 짧고 간결하게 유지하도록 가이드라인 업데이트 - 쿼타 기반 및 알림 텍스트 포맷을 '숫자%' 형식으로 통일
1 participant
Summary
.openCodeand.openCodeZenthrough updated docsTesting