System: Access: Tester convert to MVC#10071
Conversation
* working * .. * - * tt * Update tester.xml * p * Update tester.volt * remove line * enter * Update tester.volt
|
Offering a PR right away skips the triage, discussion and design phase. I would recommend opening an issue first, ask for opinions, and starting to work on something after some initial discussion took place. Skipping ahead in the process is not even something that I do myself too often, because planning is too important. Check out how I usually approach things, I create issues, brainstorm a bit, see what kind of opinions I get, and slowly scope out the implementation. I know that easy wins feel good, yet sticking to a well established process inside this repository benefits everybody. I'm not shooting this down btw, leave it open, I just wanted to give general pointers how collaboration can be improved. |
|
Would you be kind enough to open a demonstration issue for this PR so that I can better understand your suggested method of soliciting feedback? I would really appreciate it, as I appreciate your communication comments. |
|
I think something like this shows how I approach things: An issue was created, I was assigned to it, then I did some scoping and thought about how to approach it (in the open so people can give feedback or complain). That's the kind of process I envision, but it also takes time. The key here is that a small issue with a small scope is created, and then assigned to somebody to work on. Changing core infrastructure with a rewrite of a component is something that should be discussed beforehand. A small scoped feature like the Unbound nxdomain or Dnsmasq no-ping example you did recently that has a very low footprint are usually okay as drive by contributions without deeper discussions. |
|
@AdSchellevis Have you taken a look? Obviously, no pressure, just to keep anything in mind for #10084 |
If its not worthwhile, let me know :)