Services: Kea DHCPv4/6: Add decline_probation_period and set lower default to mitigate faulty client implementations to consume the whole pool#10294
Merged
Conversation
…fault to mitigate faulty client implementations to consume the whole pool.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important notices
Before you submit a pull request, we ask you kindly to acknowledge the following:
If AI was used, please disclose:
Describe the problem
A faulty client implementation can cycle through all available leases in a pool, all declined addresses will be reserved for 24 hours with the current defaults.
Describe the proposed solution
Add:
https://kea.readthedocs.io/en/latest/arm/dhcp4-srv.html#duplicate-addresses-dhcpdecline-support
https://kea.readthedocs.io/en/latest/arm/dhcp6-srv.html#duplicate-addresses-dhcpdecline-support
Set a lower default to 10 minutes. In very large networks this might need to be increased, but for default /24 networks this seems to be a good default.
Related issue
Fixes: #10285
Fixes: https://forum.opnsense.org/index.php?topic=51324.45