Skip to content

Change <select> class to "selectpicker".#2513

Closed
kekek2 wants to merge 1 commit intoopnsense:masterfrom
kekek2:selectpict2
Closed

Change <select> class to "selectpicker".#2513
kekek2 wants to merge 1 commit intoopnsense:masterfrom
kekek2:selectpict2

Conversation

@kekek2
Copy link

@kekek2 kekek2 commented Jul 4, 2018

No description provided.

@AdSchellevis
Copy link
Member

@kekek2 please test these kind of changes before committing, the first file I'm trying to validate has style issues

image
vs the original
image

Which isn't an improvement, eventually changed it to (8857213)
image

Which obviously cost more time then just do a search replace on the <select> tag

Next one on the list wash the phase1 page, which has items that are nicely hidden using javascript, which needs the proper changes to prevent the following from happening:

image

Please feel free to open another pull request if you're going to test the pages locally first, I'm going to close this one for now since it has too many issues.

fichtner pushed a commit that referenced this pull request Aug 10, 2018
@kekek2 kekek2 deleted the selectpict2 branch August 8, 2019 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants