monit: Support declaring dependencies#3001
Merged
AdSchellevis merged 1 commit intoopnsense:masterfrom Jan 16, 2019
Merged
Conversation
Member
|
@fbrendel thanks for review. version bump sounds good. Ideall both should hit 19.1, though I yield to @AdSchellevis on this topic |
AdSchellevis
added a commit
that referenced
this pull request
Jan 16, 2019
Member
|
@awerner thanks, I clarified the help message a bit, just let me know if it should be different. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows setting dependencies in the UI. This allows advanced check behaviour, e.g. VPN <- hosts behind VPN <- service behind VPN on host.
At the moment, the selection of the service as its own dependency is possible, monit shows a dependency loop error in that case with a helpful message. I'm unsure how to restrict the available services to exclude itself from the dependency list.