Add gateway alerts to Monit, for #2919#3025
Merged
AdSchellevis merged 4 commits intoopnsense:masterfrom Dec 9, 2018
Merged
Conversation
MichaelDeciso
changed the title
AdSchellevis
requested changes
Dec 7, 2018
fichtner
reviewed
Dec 7, 2018
fichtner
reviewed
Dec 7, 2018
|
|
||
| use OPNsense\Base\BaseModelMigration; | ||
|
|
||
| class M1_0_7 extends BaseModelMigration |
Member
There was a problem hiding this comment.
In general, shouldn't we be starting to use a "plugin" directory to bring these scripts in and avoid the model migration?
Member
There was a problem hiding this comment.
@fichtner I think we should make sure the current construction can function first, doing this properly providing backward compatibility will be quite difficult (if possible).
We'll see where we end up, original goal was to replace the notices with Monit, let's start improving what there is now step by step.
This is ugly, but doing so under instructions.
MichaelDeciso
force-pushed
the
feature/gateway-change-monit
branch
from
3e940cb to
ba689fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.