Remove legacy SMTP notices (for #2919)#3031
Merged
AdSchellevis merged 4 commits intoopnsense:masterfrom Dec 16, 2018
Merged
Conversation
fichtner
approved these changes
Dec 10, 2018
Member
fichtner
left a comment
fichtner
left a comment
There was a problem hiding this comment.
Lovely. An a but jealous about not committing this. ;)
FWIW, system: settings: notification needs removal. Its config.xml settings require an audit to see where it might still be used and monit‘s import smtp settings button should be a hard-wired migration path for when monit doesn’t have smtp settings yet.
Nevertheless, nice work!
fichtner
reviewed
Dec 10, 2018
…stem/Settings/Notifications
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be the last chapter in the legacy notices saga - their retirement.