Skip to content

firewall: live view improvments#4402

Closed
devNan0 wants to merge 4 commits intoopnsense:masterfrom
devNan0:feat-firewall-live-view-improvements
Closed

firewall: live view improvments#4402
devNan0 wants to merge 4 commits intoopnsense:masterfrom
devNan0:feat-firewall-live-view-improvements

Conversation

@devNan0
Copy link

@devNan0 devNan0 commented Oct 7, 2020

Add:

  • does not contain filter condition
  • is not filter condition
  • proto filter

Changed:

  • Sorting of interface_name

Remove:

  • Duplicate dst entry in filter_tag list

Closes: #4299 and #4365 point 3

Work in Progress

@AdSchellevis AdSchellevis self-assigned this Oct 7, 2020
@lattera
Copy link
Contributor

lattera commented Dec 10, 2020

I could make use of this in several OPNsense deployments. Any objections to merging this?

@AdSchellevis
Copy link
Member

yes, it's in draft state for good reasons.

@AdSchellevis
Copy link
Member

@lattera while here, can you check https://github.com/HardenedBSD/hardenedBSD/issues/388 by the way. one of our people found the reason why dtrace didn't work on our end.

@lattera
Copy link
Contributor

lattera commented Dec 10, 2020

yes, it's in draft state for good reasons.

I'm curious what those reasons are.

@devNan0
Copy link
Author

devNan0 commented Dec 10, 2020

Ahhh... Sorry shame on me... forgot about the last points. Will commit and finish this draft in the next days.

Sorry for the delay :(

@devNan0
Copy link
Author

devNan0 commented Dec 19, 2020

Changed sorting of interface_name
Before:
image
After:
image

Added proto filter option to solve #4365 point 4

But i don´t really know how to implement host and port filter without a mess in the code.
@AdSchellevis maybe you could give me a hint.

@devNan0 devNan0 marked this pull request as ready for review December 21, 2020 12:01
@TheLinuxGuy
Copy link

Thanks for working on this! I was also looking for "is not" filtering.

@AdSchellevis
Copy link
Member

@devNan0 thanks, I've pulled it in in different commits while testing the functionality. not sure what the intent of "proto" was since protoname is already the translated variant (udp, tcp). feel free open another ticket / PR to discuss further additions.

fichtner pushed a commit that referenced this pull request Jan 10, 2021
fichtner pushed a commit that referenced this pull request Jan 13, 2021
oshogbo pushed a commit to DynFi/opnsense-core that referenced this pull request Mar 3, 2022
oshogbo pushed a commit to DynFi/opnsense-core that referenced this pull request Mar 3, 2022
oshogbo pushed a commit to DynFi/opnsense-core that referenced this pull request Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: Add 'is not' & 'no contains' to Firewall / Live View

4 participants