LDAP minor fixes

[kulikov-a]

Hi!
based on https://forum.opnsense.org/index.php?topic=21605.0

• baseDN igonred in search function if ldapauthcontainers is set. help text for "Authentication containers" input fixed
  

  core/src/opnsense/mvc/app/library/OPNsense/Auth/LDAP.php

  Lines 160 to 163 in 25959a4

  	$searchpaths = array($this->baseSearchDN);
  	if (!empty($this->ldapAuthcontainers)) {
  	$searchpaths = explode(';', $this->ldapAuthcontainers);
  	}

• In select "Authentication containers" modal Close button is actually a Save button (writes changes to the "Authentication containers" input)

• Some debug info added to System: Access: Tester page for LDAP servers
  
  

thanks!

[AdSchellevis]

@kulikov-a maybe we better add a method getLastErrors() for the error feedback and move this into a separate array, it makes it more explicit that this is error feedback and not something returned by the authenticator. Other than that it's definitely an improvement to make sure errors are returned to the user here.

[kulikov-a]

@AdSchellevis
thanks! more correct of course
I will try to do so. for now I'm converting it to a draft

[kulikov-a]

@AdSchellevis it's kind of done.

• moved errors to a separate array.
• slightly tweaked the logLdapError function: it turned out that a LDAP_OPT_ERROR_STRING can contain not only commas but also new lines and even tabs special characters.
• added Cancel button to "Authentication containers" modal.
• added some debug (and the message for this case in modal window) for "Authentication containers" empty search results
  (https://forum.opnsense.org/index.php?topic=21605.msg103543#msg103543)

please take a look when you have time

[AdSchellevis]

@kulikov-a looks good, thanks, I'll pull it in to master, haven't tried it myself yet, but don't see any reason why it shouldn't.

[kulikov-a]

Wow! thanks!!!

[AdSchellevis]

@kulikov-a made a small adjustment after testing (3277c0b), when you can't connect, there's an ldap connect error but no LDAP_OPT_ERROR_STRING, so it's better to omit it in that case.

[kulikov-a]

@AdSchellevis thanks! it is always better to add existing ones )
I should have noticed it. thank!