IPsec public keys: provide generation function within GUI#5449
Closed
8191 wants to merge 2 commits intoopnsense:masterfrom
Closed
IPsec public keys: provide generation function within GUI#54498191 wants to merge 2 commits intoopnsense:masterfrom
8191 wants to merge 2 commits intoopnsense:masterfrom
Conversation
8191
force-pushed
the
ipsec/pubkey
branch
2 times, most recently
from
36c7333 to
a7bc617
Compare
AdSchellevis
reviewed
Jan 2, 2022
Member
|
@8191 it might also be an option to only add a drop down "generate new key", which by default is set to no, otherwise is using the key size. In which case you can move the responsibility to the controller and keep the frontend implementation simpler. |
Member
Author
|
@AdSchellevis Thanks for the review, I've incorporated your comments. Regarding the UI part: yes, having it in the controller might be better from a design point of view, but the downside is, that the user needs to reopen the already closed edit window to see the generated key (which he needs to distribute very likely). |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide a "Generate" button in the IPsec RSA keys dialog to generate public/private keys:
Proposals for a better/different user interface are welcome...