Unbound: convert advanced page to MVC#6050
Merged
swhite2 merged 3 commits intoopnsense:masterfrom Sep 27, 2022
Merged
Conversation
swhite2
added a commit
that referenced
this pull request
Sep 30, 2022
Small addition to #6050: - Move private/insecure domains to advanced as its intended use has a larger scope than DNSBLs only. Fixes #5256 - Extends the migration to also include these domains. - leftover cleanup of legacy settings in migration. - Adds the `serve-expired-reply-ttl`, `serve-expired-ttl`, `serve-expired-ttl-reset`, `serve-expired-client-timeout` options. These options are hidden until the `serve-expired` checkbox is checked, and indented to signify a relationship. - Removes all dropdowns and instead provides numeric fields to input raw values for more control and less "guessing" of what is acceptable. - Removes default settings to prevent mismatches with upstream in the future. It's probably best to refer to the Unbound documentation in our own documentation. - Previously, `rrset-cache-size` and `outgoing-range` were implicitly set. These are now input fields. The migration code will take care of legacy setting assumptions. Fixes #5978 Fixes #5795
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log ReplyandTag Queries and Repliesoptions to enhance logging capabilities as well.