Skip to content

mvc: $timestamp is undefined in getRevisionContext()#7500

Closed
fichtner wants to merge 1 commit intomasterfrom
coverity_work
Closed

mvc: $timestamp is undefined in getRevisionContext()#7500
fichtner wants to merge 1 commit intomasterfrom
coverity_work

Conversation

@fichtner
Copy link
Member

As spotted by coverity... we could also ditch the condition but it looked like we could start passing the timestamp around, maybe even omitting the need for empty check since it's only called once?

@fichtner fichtner requested a review from AdSchellevis May 31, 2024 07:28
@fichtner fichtner self-assigned this May 31, 2024
@fichtner
Copy link
Member Author

The offending line was this one:

$revision['time'] = empty($timestamp) ? microtime(true) : $timestamp;

@AdSchellevis
Copy link
Member

@fichtner I think I rather ditch the parameter in this case. I'll do that later and close this PR, thanks!

@fichtner
Copy link
Member Author

Ok 👍

fichtner pushed a commit that referenced this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants