Skip to content

use zpool.cache when importing pools at boot#7559

Closed
nt1 wants to merge 3 commits intoopnsense:masterfrom
nt1:respect-zpool-cache
Closed

use zpool.cache when importing pools at boot#7559
nt1 wants to merge 3 commits intoopnsense:masterfrom
nt1:respect-zpool-cache

Conversation

@nt1
Copy link
Copy Markdown

@nt1 nt1 commented Jun 26, 2024

Fixes issue #7553

@fichtner
Copy link
Copy Markdown
Member

Thanks. Ideally hardcoding cache files should be avoided. It just looks like a maintenance spot further down the road. As said I’ll take a look when I’m back.

@fichtner fichtner self-assigned this Jun 26, 2024
@nt1
Copy link
Copy Markdown
Author

nt1 commented Jun 26, 2024

Minimally, I'll move those string constants to a better place for the sake of maintainability. This would also be a good place for a link to openzfs zpool cache documentation.

@fichtner fichtner linked an issue Aug 1, 2024 that may be closed by this pull request
2 tasks
@fichtner
Copy link
Copy Markdown
Member

fichtner commented Aug 1, 2024

To be frank I'd prefer something like

ZPOOL_IMPORT_PATH="/dir1:/dir2"
export ZPOOL_IMPORT_PATH

The docs say:

ZPOOL_IMPORT_PATH The search path for devices or files to use with the pool. This is a colon-separated list of directories in which zpool looks for device nodes and files. Similar to the -d option in zpool import.

But the fun part is nothing really says what the compatible directory default is nor does the code make an effort to bootstrap a default.

Cheers,
Franco

fichtner added a commit that referenced this pull request Aug 1, 2024
@fichtner
Copy link
Copy Markdown
Member

fichtner commented Aug 1, 2024

Ok from the old code "/dev" should suffice so if you can let me know if this works as well... e7d8052

fichtner added a commit that referenced this pull request Aug 13, 2024
@fichtner
Copy link
Copy Markdown
Member

Shipping 701dff4 can't hurt so I will.

@fichtner fichtner closed this Aug 13, 2024
fichtner added a commit that referenced this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

zpool cache not respected by opnsense

2 participants