Skip to content

Docs/clarify static lease register#8028

Closed
Vaarlion wants to merge 2 commits intoopnsense:masterfrom
Vaarlion:docs/Clarify_static_lease_register
Closed

Docs/clarify static lease register#8028
Vaarlion wants to merge 2 commits intoopnsense:masterfrom
Vaarlion:docs/Clarify_static_lease_register

Conversation

@Vaarlion
Copy link
Copy Markdown

Add some documentation to clarify #7990

I could not run the test on my computer, the makefile being for BSD system.
I'm hopping for an internal CI on your side ?

<type>checkbox</type>
<help>
<![CDATA[If this option is set, then DHCP static mappings will be registered in Unbound, so that their name can be resolved.
DHCP lease without a specified static ip cannot be register.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Static mappings are not leases. IP addresses are more or less implied for DNS to resolve but clarifying it in the first sentence wouldn’t hurt I suppose for all those who do read…

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does DHCP static mapping which doesn't contain a static ip will not be registered sound more accurate ?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You want to make it affirmative:

… static mappings with an IP address will be registered…

@AdSchellevis
Copy link
Copy Markdown
Member

timeout

@Vaarlion
Copy link
Copy Markdown
Author

My bad sorry, i had other thing rise and completely forgot about this....
It look like i was just being dumb anyway :)

@fichtner
Copy link
Copy Markdown
Member

@Vaarlion no worries. appreciate the PR and discussion yet sometimes we also have to discuss and wait for similar reports for these types of suggestions.. sometimes documentation also makes sense.. here it looks like it's ok as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants