firewall: Change toggle_log icon to help visibility of enabled/disabled status#9704
Merged
firewall: Change toggle_log icon to help visibility of enabled/disabled status#9704
Conversation
Member
|
I'm mostly ok with this but visually we shouldn't colour/mute action buttons. |
Member
Author
|
Sure I remove the color. I already had feedback from @swhite2 that he is okay with the icons as well. |
Monviech
force-pushed
the
firewall-logging-icon
branch
from
ed326fa to
60da435
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #9693
I also had issues seeing enabled and disabled after using it for a while, had to always use the tooltip.
I think this is the best solution, though open for feedback for other fa-icons.