Translation: Fix some plugins#122
Conversation
|
@fraenki please verify that this changes are working with your plugins. |
| <b>{{ lang._("Please read the official %sLet's Encrypt documentation%s before using this plugin. Otherwise you will easily hit it's %srate limits%s and thus all your attempts to issue a certificate will fail.") | format('<a href="https://letsencrypt.org/how-it-works/">', '</a>', '<a href="https://letsencrypt.org/docs/rate-limits/">', '</a>') }}</b>{{ lang._("Please use Let's Encrypts %staging servers%s when using this plugin for the first time or while testing a new validation method. You'll have to re-issue your certificates when switching from staging to production servers to get valid certificates.") | format('<a href="https://letsencrypt.org/docs/staging-environment/">', '</a>') }} | ||
| <br/> | ||
| {{ lang._("Please use the ") }}<a href="https://github.com/opnsense/plugins/issues">{{ lang._("GitHub Issue Tracker ") }}</a>{{ lang._("to report bugs or request new features.") }} | ||
| {{ lang._("Please use the %sGitHub Issue Tracker%s to report bugs or request new features.") | format('<a href="https://github.com/opnsense/plugins/issues">', '</a>') }} |
There was a problem hiding this comment.
@fraenki Gegen eine solche Codebase habe ich 2 Jahre lang gearbeitet. Das wollen wir nicht wieder haben sondern die Strings sollen sauber zusammenhängen.
There was a problem hiding this comment.
FWIW, "GitHub" may not always be GitHub :P
There was a problem hiding this comment.
But for now it is ;)
It could be omitted but that is another topic.
There was a problem hiding this comment.
@fabianfrz Is there a guideline for this in the docs somewhere? This would be useful.
There was a problem hiding this comment.
Sadly not for translations...
There was a problem hiding this comment.
Sadly not for translations...
this is in the docs of phalcon (had to lookup this too).
There was a problem hiding this comment.
@fabianfrz I vote for a short paragraph in the OPNsense coding guidelines... maybe you could contribute it :)
There was a problem hiding this comment.
@fraenki: I sent an email to @jschellevis about this topic.
There was a problem hiding this comment.
Would already refer "%sissue tracker%s"
|
@fichtner your approval is missing |
| <br/> | ||
| <br/> | ||
| <p>Includes code from the <a href="https://github.com/Neilpang/acme.sh">Neilpang/acme.sh</a> project. Licensed under GPLv3.<br/>Let's Encrypt™ is a trademark of the Internet Security Research Group. All rights reserved.</p> | ||
| <p>{{ lang._("This plugin includes code from the %sNeilpang/acme.sh%s project.") | format('<a href="https://github.com/Neilpang/acme.sh">', '</a>' ) }} {{ lang._('Licensed under GPLv3.') }}<br/>{{ lang._('Let's Encrypt™ is a trademark of the Internet Security Research Group. All rights reserved.') }}</p> |
There was a problem hiding this comment.
Should make this more flexible with "%s" instead of "%sNeilpang/acme.sh%s" ? One doesn't make sense without the other. The license is also part of the first string.
| <b>{{ lang._("Please read the official %sLet's Encrypt documentation%s before using this plugin. Otherwise you will easily hit it's %srate limits%s and thus all your attempts to issue a certificate will fail.") | format('<a href="https://letsencrypt.org/how-it-works/">', '</a>', '<a href="https://letsencrypt.org/docs/rate-limits/">', '</a>') }}</b>{{ lang._("Please use Let's Encrypts %staging servers%s when using this plugin for the first time or while testing a new validation method. You'll have to re-issue your certificates when switching from staging to production servers to get valid certificates.") | format('<a href="https://letsencrypt.org/docs/staging-environment/">', '</a>') }} | ||
| <br/> | ||
| {{ lang._("Please use the ") }}<a href="https://github.com/opnsense/plugins/issues">{{ lang._("GitHub Issue Tracker ") }}</a>{{ lang._("to report bugs or request new features.") }} | ||
| {{ lang._("Please use the %sGitHub Issue Tracker%s to report bugs or request new features.") | format('<a href="https://github.com/opnsense/plugins/issues">', '</a>') }} |
There was a problem hiding this comment.
Would already refer "%sissue tracker%s"
|
@fichtner applied your change request |
(cherry picked from commit 393557c)
3 participants
Feedback from plugin maintainers is welcome.