sysutil/apuled Monitor IP revision (again) #1413
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fichtner
reviewed
Jul 17, 2019
| PLUGIN_DEVEL= yes | ||
| PLUGIN_COMMENT= PC Engine APU LED control | ||
| PLUGIN_MAINTAINER= julio@cloudfence.com.br | ||
| PLUGIN_NAME= apuled |
Member
There was a problem hiding this comment.
this still looks off, should be tabs not spaces
fichtner
reviewed
Jul 17, 2019
| @@ -1,32 +1,34 @@ | |||
| #!/bin/sh | |||
| # Copyright (c) 2019 Cloudfence - Julio Camargo (JCC) | |||
Member
There was a problem hiding this comment.
this is also off. second line empty "#", third line down indent is "# " (one space only).
Member
|
almost but not quite, you can see the differences here: https://github.com/opnsense/plugins/pull/1413/files |
fichtner
added a commit
that referenced
this pull request
Jan 3, 2020
Member
|
Merged manually via 2d0c6ac, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fichtner please check if I did right this time! ;-)