Skip to content

Acme dns alias mode#1492

Closed
blablup wants to merge 2 commits intoopnsense:masterfrom
blablup:acme_DNS-alias-mode
Closed

Acme dns alias mode#1492
blablup wants to merge 2 commits intoopnsense:masterfrom
blablup:acme_DNS-alias-mode

Conversation

@blablup
Copy link
Copy Markdown
Contributor

@blablup blablup commented Sep 4, 2019

Patch to allow dns alias mode (feature #1490 )

@fraenki fraenki self-assigned this Sep 9, 2019
@fraenki fraenki added the feature Adding new functionality label Sep 9, 2019
@fraenki fraenki self-requested a review September 10, 2019 16:03
fraenki
fraenki requested changes Sep 10, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@fraenki fraenki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blablup I think there's something wrong with this pull-request, commit 4ecd40d shouldn't be part of it since it has nothing to do with DNS alias mode, right? Please remove this commit from the PR :)

@fraenki
Copy link
Copy Markdown
Member

fraenki commented Sep 10, 2019 •
edited
Loading

@blablup I've cherry-picked commit c257706. Thanks for your contribution!

@fraenki fraenki closed this Sep 10, 2019
@fraenki fraenki mentioned this pull request Sep 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fraenki fraenki fraenki requested changes

Assignees

@fraenki fraenki

Labels

feature Adding new functionality

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@blablup @fraenki