WIP net/frr: Add BGP password support#2800
Merged
AdSchellevis merged 15 commits intomasterfrom Feb 3, 2022
Merged
Conversation
Member
|
@AdSchellevis this doesn't look right from GitHub |
Member
Author
|
@fichtner hmm, this is odd, let me try to rebase again and see if this is fixable. GitHub was also down from my end yesterday evening, odd |
refactor security association handling. Try to figure out which entries belong to FRR before removing them, so neighbor changes won't be left on the machine after apply. Flush our desired configuration into /usr/local/etc/frr/sa_policies.conf for easy reading and testing. Since we don't know if passwords have changed, we will have to drop SA's first. When this is a bit bumpy, we may also try to alter the existing SA's, this shouldn't be too hard to add later on.
AdSchellevis
force-pushed
the
frr_bgp_password
branch
from
782cedc to
7b1af56
Compare
Member
Author
|
if @mimugmail agrees with the content, we should squash merge it and rewrite the commit message, the trail is a bit messy now. |
Member
|
Sure, love it. Thx for your help :) |
mimugmail
approved these changes
Feb 3, 2022
Member
Author
|
@mimugmail you're welcome, it's merged |
Member
|
@AdSchellevis works great on my end. Let's let it sleep in devel until 22.1.1 so ppl will have time to test a devel pkg :) |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replacement for #2645, adding setkey rafactor in 782cedc