net/frr register_sas script/setkey add SAD entries for both IPv6 and IPv4#3345
Merged
AdSchellevis merged 1 commit intoopnsense:masterfrom Mar 12, 2023
as8net:patch-1
Merged
net/frr register_sas script/setkey add SAD entries for both IPv6 and IPv4#3345AdSchellevis merged 1 commit intoopnsense:masterfrom as8net:patch-1
AdSchellevis merged 1 commit intoopnsense:masterfrom
as8net:patch-1
Conversation
OPNsense supports BGP on both IPv4 and IPv6, but the current frr/setkey script implementation only adds SAD entries for IPv4. Changing -4 to -n keeps filtering on numeric addresses, but adds SAD entries for both IPv4 and IPv6 instead of only IPv4. Tested working on a Vultr VM with BGP enabled and MD5 password on the Vultr side.
as8net
changed the title
as8net
changed the title
mimugmail
approved these changes
Mar 12, 2023
Member
mimugmail
left a comment
mimugmail
left a comment
There was a problem hiding this comment.
Looks good to me, thx. Its @AdSchellevis Code, maybe he wants to have a look too
Member
|
@as8net looks good indeed, thanks! |
AdSchellevis
pushed a commit
that referenced
this pull request
May 9, 2023
OPNsense supports BGP on both IPv4 and IPv6, but the current frr/setkey script implementation only adds SAD entries for IPv4. Changing -4 to -n keeps filtering on numeric addresses, but adds SAD entries for both IPv4 and IPv6 instead of only IPv4. Tested working on a Vultr VM with BGP enabled and MD5 password on the Vultr side.
This was referenced Jul 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OPNsense supports BGP on both IPv4 and IPv6, but the current frr/setkey script implementation only adds SAD entries for IPv4. Changing -4 to -n keeps filtering on numeric addresses, but adds SAD entries for both IPv4 and IPv6 instead of only IPv4.
Tested working on a Vultr VM with BGP enabled and MD5 password on the Vultr side.