Skip to content

net/quagga: add a firewall rule for unicast traffic#349

Merged
fabianfrz merged 1 commit intomasterfrom
quagga_fw_rule
Nov 28, 2017
Merged

net/quagga: add a firewall rule for unicast traffic#349
fabianfrz merged 1 commit intomasterfrom
quagga_fw_rule

Conversation

@fabianfrz
Copy link
Copy Markdown
Member

@fabianfrz fabianfrz commented Oct 28, 2017

part of #346
Waiting for feedback of the Ticket author.

@fabianfrz fabianfrz added the bug Production bug label Oct 28, 2017
@fabianfrz fabianfrz self-assigned this Oct 28, 2017
@fabianfrz fabianfrz changed the title quagga: add a firewall rule for unicast traffic net/quagga: add a firewall rule for unicast traffic Oct 28, 2017
@fabianfrz
Copy link
Copy Markdown
Member Author

@fichtner can I merge this as I don't want a stale PR when switching the backend?

@fabianfrz fabianfrz requested a review from fichtner November 28, 2017 16:30
Copy link
Copy Markdown
Member

@fichtner fichtner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it fixes a bug, sure

@fabianfrz fabianfrz merged commit 858a6d9 into master Nov 28, 2017
@fabianfrz fabianfrz deleted the quagga_fw_rule branch November 28, 2017 16:47
@fabianfrz
Copy link
Copy Markdown
Member Author

@fichtner now I will adjust the files for FRR

@fichtner
Copy link
Copy Markdown
Member

can you make a copy so we can cleanly discontinue quagga plugin?

@fabianfrz
Copy link
Copy Markdown
Member Author

@fichtner I would prefer making an empty os-quagga package with an os-frr dependency

@fichtner
Copy link
Copy Markdown
Member

no just a os-frr people can flip / install on their own

the models stay the same so it's just that maintenance effort of installing the other plugin

@fichtner
Copy link
Copy Markdown
Member

(And I believe os-quagga will auto-deinstall if os-frr is used)

@fabianfrz
Copy link
Copy Markdown
Member Author

We should also think about the conflict of the stale quagga package which conflicts with frr. This is why I plan this change to the end of the release.

@fichtner
Copy link
Copy Markdown
Member

see my last comment, I think this works automatically if people install os-frr plugin (because they need to as going to be stated in the release notes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Production bug

Development

Successfully merging this pull request may close these issues.

2 participants