dns/ddclient: Treat 204 response as successful

[sudnam]

Treat a 204 response code as successful when using the dyndns2 provider. Should help with #3585 (by using the custom provider) until we get a proper provider for domeneshop.

[AdSchellevis]

@sudnam how about 7c6fccd ?

[fichtner]

yeah, 2xx range should indicate ok. that would have been my comment as well :)

[sudnam]

@sudnam how about 7c6fccd ?

Yeah, that works as well and is a bit nicer I guess. :) Thanks for fixing!

[sudnam]

@AdSchellevis Just got the update to 1.16.1 on my home router and still it complains about a 204 response (Account xxx [custom - dydns.domain.com] failed to set new ip [204 - ]). Am I missing something or is there something more that needs to be done?

[fichtner]

Will be released in 23.7.8.

[sudnam]

So it wont work in <23.7.8 even though it says that 1.16_1 is installed and the changelog mentions the fix for this?

[fichtner]

You are right, it’s already in 23.7.7. Native backend? Dyndns2?

[sudnam]

Native backend and custom service with 'Custom GET'. My understanding is that that should go through the same code as dyndns2.

[AdSchellevis]

I would expect so, yes, looking at the code on my end, it seems to include the adjusted line:

# grep 'req.status_code' /usr/local/opnsense/scripts/ddclient/lib/account/dyndns2.py
            if 200 >= req.status_code < 300:
                        self.description, self.current_address, req.status_code, req.text.replace('\n', '')

[fichtner]

Old daemon still running?

[sudnam]

I also have the expected code in place and tried restarting the daemon but still no luck, getting the same error.

[AdSchellevis]

@sudnam ok, something is off with my code, I'll take a look

[AdSchellevis]

@sudnam ok, I'm an idiot, even while reading it twice, I. didn't see the apparent issue here, can you try f6f72bb ?

[sudnam]

Right, I totally missed that as well... Is there an easy way to test out that commit in a running system? Without compiling a package and stuff yourself.

[fichtner]

# opnsense-patch -c plugins f6f72bb

[sudnam]

@fichtner Perfect, thanks!

@AdSchellevis Now I'm getting a raised fatal error (list index out of range) instead when it is trying to update with the same config as before.

[AdSchellevis]

no clue, you probably have to debug further, nothing else has changed here. the most likely crash point is

plugins/dns/ddclient/src/opnsense/scripts/ddclient/lib/account/dyndns2.py

Line 108 in f6f72bb

self.update_state(address=self.current_address, status=req.text.split()[0])

There's a notice message earlier

[sudnam]

Right, that should be it. Since the response is 204, req.text will contain an empty string which will lead to an empty array when split is called on it.

I'll have a look at a fix later tonight.

[AdSchellevis]

ok, here you go 85e4a25

[sudnam]

Thank you very much for all the help!