Skip to content

Set up networks, prefix lists, and route maps for OSPF6#4247

Closed
fmeppo wants to merge 1 commit into
opnsense:masterfrom
fmeppo:master
Closed

Set up networks, prefix lists, and route maps for OSPF6#4247
fmeppo wants to merge 1 commit into
opnsense:masterfrom
fmeppo:master

Conversation

@fmeppo
Copy link
Copy Markdown
Contributor

@fmeppo fmeppo commented Sep 22, 2024

This should provide UI as well as template files to implement network, prefix list, and route map config for OSPF6.

@mimugmail
Copy link
Copy Markdown
Member

Thx, I'll merge it on my test machine and give it a shot

@AdSchellevis AdSchellevis self-assigned this Sep 22, 2024
@fmeppo
Copy link
Copy Markdown
Contributor Author

fmeppo commented Sep 27, 2024

@mimugmail , @AdSchellevis : Any thoughts here? Wondering if there's any re-work I should do this weekend, or if this is looking sane enough to merge.

@AdSchellevis
Copy link
Copy Markdown
Member

@fmeppo it has been extremely busy, but it's on my list to review and merge this. At a first glance I don't expect a lot is needed, but let me handle the modifications when needed so you don't have additional work. My intention is to reformat some older areas to align the code with how it looks in core, but I do need some time to work on it.....

@fmeppo
Copy link
Copy Markdown
Contributor Author

fmeppo commented Sep 28, 2024

I'm happy to take a bit of extra work here - if you can give me a couple examples, I can try matching styles. I'm sure a few cleanups can be worked in at the same time (or stacked on top, if extensive).

AdSchellevis added a commit that referenced this pull request Sep 28, 2024
commit f70158ab043ec0c2d5b31f469b0b36c3e1445df6
Author: Ad Schellevis <ad@opnsense.org>
Date:   Sat Sep 28 22:53:12 2024 +0200

    Routing: OSPFv3 - style cleanups for #4247

commit 549ee36
Author: Mike Shuey <shuey@fmepnet.org>
Date:   Sat Sep 21 11:47:05 2024 -0700

    Set up networks, prefix lists, and route maps for OSPF6
@AdSchellevis
Copy link
Copy Markdown
Member

@fmeppo this should be it 1d692d9 after planned cleanups for these files. Can you double check the current state?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants